Repository navigation
Add 'Wait Until Page Not Contains Element' -keyword - #375
just-be-dev merged 5 commits into
Conversation
|
Well of course I managed to typo my commit message so now it is misleading Edit: |
|
This should probably be |
There was a problem hiding this comment.
Should this be Wait Until Page Contains Element?
|
I used the following ticket as a reference for missing keywords: |
|
@emanlove, what do you think on the wording? |
|
@zephraph We had a discussion about wording a while back. It centred around the idea that the java port of the Selenium2Library had some keywords that weren't yet within this library. As some got added we tended toward using the same keyword name. But for some of them they we too grammatically incorrect. Personally I think it should be ...Does Not Contain... Looking to see if I can find that discussion... |
|
Trying to do the changes to the keyword name within a few days. I agree with you that |
|
@molsky, Once you rebase and make those changes I'll merge this for you. If you need help rebasing let me know. Thanks for contributing! |
|
Changes done and I hope that I did rebasing and pushing changes in correct way. |
|
Awesome job! Thanks for contributing. =] |
…ent2 Add 'Wait Until Page Does Not Contain Element' keyword
I hope that this is implemented in proper way.